[webkit-reviews] review granted: [Bug 44115] [CHROMIUM] Eliminate a memcpy() from the canvas.drawImage(canvas, ...) path. : [Attachment 64602] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 17 10:59:00 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 44115: [CHROMIUM] Eliminate a memcpy() from the canvas.drawImage(canvas,
...) path.
https://bugs.webkit.org/show_bug.cgi?id=44115
Attachment 64602: Patch
https://bugs.webkit.org/attachment.cgi?id=64602&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h:82
+ BitmapImageSingleFrameSkia(const SkBitmap&);
should this be marked 'explicit' just in case?
WebCore/platform/graphics/skia/NativeImageSkia.h:49
+ NativeImageSkia(const SkBitmap&);
nit: mark this 'explicit'?
R=me
More information about the webkit-reviews
mailing list