[webkit-reviews] review requested: [Bug 42949] REGRESSION: Incorrect repaint on scrolling with position:fixed element on Windows : [Attachment 64606] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 10:35:22 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has asked  for review:
Bug 42949: REGRESSION: Incorrect repaint on scrolling with position:fixed
element on Windows
https://bugs.webkit.org/show_bug.cgi?id=42949

Attachment 64606: v1 patch
https://bugs.webkit.org/attachment.cgi?id=64606&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
Here's a potential fix.  This reverts portions of
http://trac.webkit.org/changeset/63907
in an effort to not break WebKit2 scrolling.  However, I have not confirmed
that WebKit2
scrolling still works.

I think the repaintFixedElementsAfterScrolling function name is confusing since
it
doesn't actually do any repainting.  It just updates paint rects in preparation
for
scrollContentsFastPath, which does the actual painting.  So, it is necessary
that
repaintFixedElementsAfterScrolling precede scrollContentsFastPath.

Perhaps the updateCompositingLayers call should not be made from
repaintFixedElementsAfterScrolling, but I don't know enough about how the
compositor
works.


More information about the webkit-reviews mailing list