[webkit-reviews] review requested: [Bug 43988] Web Inspector: Remote Web Inspector support for QtWebKit : [Attachment 64599] patch to enable remote web inspector for qtwebkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 09:13:33 PDT 2010


Jamey Hicks <jamey.hicks at nokia.com> has asked  for review:
Bug 43988: Web Inspector: Remote Web Inspector support for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=43988

Attachment 64599: patch to enable remote web inspector for qtwebkit
https://bugs.webkit.org/attachment.cgi?id=64599&action=review

------- Additional Comments from Jamey Hicks <jamey.hicks at nokia.com>
Previous patch had two problems:
1) remote web inspector was alway enabled. Now enabled only if property
_q_webDebugServerPort is set on QWebPage instances. QtTestBrowser takes
argument -remote-inspector-port to control this property.
2) Fixed a segv on close of the QWebView window when remote inspector is
enabled.


More information about the webkit-reviews mailing list