[webkit-reviews] review canceled: [Bug 44089] [Qt] Making effective use of Document::nodesFromRect : [Attachment 64549] patch v1

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has canceled Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 44089: [Qt] Making effective use of Document::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=44089

Attachment 64549: patch v1
https://bugs.webkit.org/attachment.cgi?id=64549&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
> > +Element* QWebPagePrivate::TouchAdjuster::toElement(Node* node) const
> > +{
> > +	 return dynamic_cast<Element*>(node);
> > +}
> 
> dynamic_cast is not allowed in the WebKit. You should do isElementNode() and
static_cast instead. 

Done.

> I'm surprised this compiles for you. RTTI and exceptions should be disabled
in the build as it causes bloat. Is it not?

ExceptionCode is being widely used on WebKit/*, incluing Qt as you can see here
http://pastebin.com/kkED4Dik