[webkit-reviews] review granted: [Bug 44059] [Qt] fast/dom/Geolocation/disconnected-frame-permission-denied.html fails : [Attachment 64582] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 17 07:49:59 PDT 2010
Jeremy Orlow <jorlow at chromium.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 44059: [Qt] fast/dom/Geolocation/disconnected-frame-permission-denied.html
fails
https://bugs.webkit.org/show_bug.cgi?id=44059
Attachment 64582: Patch
https://bugs.webkit.org/attachment.cgi?id=64582&action=review
------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame-permission-den
ied.js:14
+ iframeGeolocation.getCurrentPosition(function() {
might be more clear to not have the functions be inline...
LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame-permission-den
ied.js:18
+ error = e;
I would have done window.error
r=me
More information about the webkit-reviews
mailing list