[webkit-reviews] review granted: [Bug 44097] Web Inspector: get rid of node and scoped object-specific ids. : [Attachment 64569] [PATCH] Proposed change.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 17 06:07:43 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 44097: Web Inspector: get rid of node and scoped object-specific ids.
https://bugs.webkit.org/show_bug.cgi?id=44097
Attachment 64569: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=64569&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/inspector/front-end/InjectedScript.js:411
+ var className = this._className(obj);
Simply return this._className(obj)
WebCore/inspector/front-end/InjectedScriptAccess.js:41
+ console.error("Access to injected script with no id");
These two lines can be substituted with one console.assert which also supports
stack traces.
More information about the webkit-reviews
mailing list