[webkit-reviews] review granted: [Bug 43985] Change FileStream implementation to prepare for blob resource handling : [Attachment 64540] Proposed Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 43985: Change FileStream implementation to prepare for blob resource
handling
https://bugs.webkit.org/show_bug.cgi?id=43985

Attachment 64540: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=64540&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few nits.

> diff --git a/WebCore/html/FileStream.h b/WebCore/html/FileStream.h
> +    int write(Blob* blob, long long position, int length);

param name |blob| not needed.


> diff --git a/WebCore/html/FileStreamProxy.h b/WebCore/html/FileStreamProxy.h
> +    void writeOnFileThread(Blob* blob, long long position, int length);

param name |blob| not needed.

> diff --git a/WebCore/html/FileThreadTask.h b/WebCore/html/FileThreadTask.h
> +    typedef R (T::*Method)(MP1, MP2, MP3);

I agree with Kinuko. (I understand you are doing this for consistency with the
other methods in this file but I wonder if all the methods should just handle
void returns. I'm fine with this change or changing all of them to be void.)