[webkit-reviews] review granted: [Bug 44092] Web Inspector: Add XMLHttpRequest Logging Tests : [Attachment 64554] [PATCH] http/tests/inspector/console-xhr-logging.html

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 44092: Web Inspector: Add XMLHttpRequest Logging Tests
https://bugs.webkit.org/show_bug.cgi?id=44092

Attachment 64554: [PATCH] http/tests/inspector/console-xhr-logging.html
https://bugs.webkit.org/attachment.cgi?id=64554&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Nice test, thanks for adding it!

LayoutTests/http/tests/inspector/console-xhr-logging.html:11
 +	    console.log(result);
We use convenience output() method for dumping stuff into the page. It then
gets into the results via the dump render tree standard logging in a much nicer
way.

LayoutTests/http/tests/inspector/console-xhr-logging.html:50
 +	if (WebInspector.monitoringXHREnabled)
You could do this check earlier and not do waitUntilDone in this branch.

LayoutTests/http/tests/inspector/console-xhr-logging.html:62
 +	if (!WebInspector.monitoringXHREnabled)
Ditto.