[webkit-reviews] review granted: [Bug 44001] fix test-webkitpy, add easy way to find a checkout root : [Attachment 64536] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 44001: fix test-webkitpy, add easy way to find a checkout root
https://bugs.webkit.org/show_bug.cgi?id=44001

Attachment 64536: Patch
https://bugs.webkit.org/attachment.cgi?id=64536&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py:199
 +	    # Mock out stderr to avoid unnecessary error logging.
We often use our OutputCapture class for this.

WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py:210
 +	    sys.stderr = open(os.devnull, 'a')
Yeah, OutputCapture would allow you to assert that it printed the expected
strings here.

Looks good.  OutputCapture would be better in the tests.