[webkit-reviews] review granted: [Bug 44080] String find/reverseFind methods need tidying up : [Attachment 64531] The patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 16 16:20:43 PDT 2010
Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 44080: String find/reverseFind methods need tidying up
https://bugs.webkit.org/show_bug.cgi?id=44080
Attachment 64531: The patch
https://bugs.webkit.org/attachment.cgi?id=64531&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
My only comment is that I think findCaseInsensitive should be renamed
findIgnoringCase to match equalIgnoringCase (same for the reverse find case).
Otherwise, r=me.
More information about the webkit-reviews
mailing list