[webkit-reviews] review granted: [Bug 43099] Add JavaScript API to allow a page to go fullscreen : [Attachment 63941] Part 5: FullScreen-WebCore-MediaElements
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 16 13:53:56 PDT 2010
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 43099: Add JavaScript API to allow a page to go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=43099
Attachment 63941: Part 5: FullScreen-WebCore-MediaElements
https://bugs.webkit.org/attachment.cgi?id=63941&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> + if (document()->page()->settings()->fullScreenEnabled()) {
Document has a settings() method so you don't have to go through page.
settings() can return NULL if there isn't a frame.
r=me with these changes.
More information about the webkit-reviews
mailing list