[webkit-reviews] review granted: [Bug 42960] [GStreamer] media/invalid-media-url-crash.html fails : [Attachment 62549] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 42960: [GStreamer] media/invalid-media-url-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=42960

Attachment 62549: proposed patch
https://bugs.webkit.org/attachment.cgi?id=62549&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>

>  void StreamingClient::wasBlocked(ResourceHandle*)
>  {
> +    WebKitWebSrcPrivate* priv = m_src->priv;
> +    GST_ERROR_OBJECT(m_src, "Request was blocked");
> +    GST_ELEMENT_ERROR(m_src, RESOURCE, OPEN_READ, ("Access to \"%s\" was
blocked", priv->uri), (0));
>  }

>  void StreamingClient::cannotShowURL(ResourceHandle*)
>  {
> +    WebKitWebSrcPrivate* priv = m_src->priv;

Just a minor nit, you can simply use m_src->priv->uri here instead of caching
the pointer locally. LGTM with those lines changed.