[webkit-reviews] review denied: [Bug 43714] Move filehandling into fileLoadTimer callback : [Attachment 63879] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 16 07:39:20 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 43714: Move filehandling into fileLoadTimer callback
https://bugs.webkit.org/show_bug.cgi?id=43714

Attachment 63879: Patch
https://bugs.webkit.org/attachment.cgi?id=63879&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> -void ResourceHandle::fileLoadTimer(Timer<ResourceHandle>* timer)
> +void ResourceHandle::fileLoadTimer(Timer<ResourceHandle>*)
>  {
> +    String path = firstRequest().url().path();
> +    // Windows does not enjoy a leading slash on paths.
> +    if (path[0] == '/')
> +	   path = path.substring(1);
> +
> +    int queryPos = path.find('?');
> +    if (queryPos != -1)
> +	   path.remove(queryPos);

I'm surprised that KURL::path would return a string that contains a query
component. That seems like a bad bug. Is that really happening?

It seems like it would be better to use KURL::fileSystemPath anyway.

> +    if (fileHandle == INVALID_HANDLE_VALUE) {
> +	   client()->didFail(this, ResourceError());
> +	   deref();
> +	   return;
> +    }

Where is the ref() that this deref() is balancing? I don't see it in this
patch. Was it a bug that we weren't dereffing before? We usually include a
comment at both the ref() and deref() callsites mentioning where the balancing
call is.

> +    int dotPos = path.reverseFind('.');
> +    int slashPos = path.reverseFind('/');
> +
> +    if (slashPos < dotPos && dotPos != -1) {
> +	   String ext = path.substring(dotPos + 1);
> +	  
response.setMimeType(MIMETypeRegistry::getMIMETypeForExtension(ext));
> +    }

This code seems entirely new and doesn't match the ChangeLog (which claims this
patch just moves code).


More information about the webkit-reviews mailing list