[webkit-reviews] review denied: [Bug 42811] Geolocation preemptive permissions policy is buggy : [Attachment 64483] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 16 04:36:14 PDT 2010


Steve Block <steveblock at google.com> has denied Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 42811: Geolocation preemptive permissions policy is buggy
https://bugs.webkit.org/show_bug.cgi?id=42811

Attachment 64483: patch
https://bugs.webkit.org/attachment.cgi?id=64483&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
This is still missing ChangeLogs

LayoutTests/fast/dom/Geolocation/delayed-permission-allowed-for-multiple-reques
ts.html:10
 +  <script
src="script-tests/delayed-permission-allowed-for-multiple-requests.html"></scri
pt>
This should be the .js file. Did you run the tests locally?

LayoutTests/platform/gtk/Skipped:1095
 +  fast/dom/Geolocation/delayed-multiple-permissions-denied.html
Needs updating

LayoutTests/platform/qt/Skipped:5497
 +  fast/dom/Geolocation/delayed-multiple-permissions-denied.html
Needs updating


More information about the webkit-reviews mailing list