[webkit-reviews] review granted: [Bug 43974] Geolocation requests in progress when the frame is disconnected should invoke the error callback : [Attachment 64481] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 43974: Geolocation requests in progress when the frame is disconnected
should invoke the error callback
https://bugs.webkit.org/show_bug.cgi?id=43974

Attachment 64481: Patch
https://bugs.webkit.org/attachment.cgi?id=64481&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> Instead, we should attempt to invoke the error callback for all ongoing
requests.

I think that this is a good change because it matches XMLHttpRequest (which
dispatches an abort event when window is closed). But for posterity, it would
be best to document why else we want this. Does any spec say so?

+    if (m_fatalError)
+	 return;

It might be helpful to add a comment explaining why the first error wins.

r=me. The split js-test makes me sad.