[webkit-reviews] review denied: [Bug 42811] Geolocation preemptive permissions policy is buggy : [Attachment 64421] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 16 02:10:46 PDT 2010
Steve Block <steveblock at google.com> has denied Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 42811: Geolocation preemptive permissions policy is buggy
https://bugs.webkit.org/show_bug.cgi?id=42811
Attachment 64421: patch
https://bugs.webkit.org/attachment.cgi?id=64421&action=review
------- Additional Comments from Steve Block <steveblock at google.com>
This patch is missing ChangeLog entries
LayoutTests/fast/dom/Geolocation/script-tests/delayed-multiple-permissions-allo
wed.js:1
+ description("Tests that when multiple positions are available, no callbacks
are invoked until permission is allowed.");
This is slightly misleading. There aren't multiple positions, there are
multiple requests in progress, all awaiting permission. Maybe the test should
be named delayed-permission-allowed-multiple-requests?
More information about the webkit-reviews
mailing list