[webkit-reviews] review granted: [Bug 43778] Dropping should fire textInput event : [Attachment 64462] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 15 23:32:34 PDT 2010
Tony Chang <tony at chromium.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 43778: Dropping should fire textInput event
https://bugs.webkit.org/show_bug.cgi?id=43778
Attachment 64462: Patch
https://bugs.webkit.org/attachment.cgi?id=64462&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
> diff --git a/WebCore/page/DragController.cpp
b/WebCore/page/DragController.cpp
> if (!color.isValid())
> return false;
> - if (!innerFrame)
> - return false;
I think it's correct to remove this since it's confusing with the ASSERT above.
I wonder if there's some risk that it was needed to avoid a crash (ASSERT
doesn't trigger in release builds), but without a test case, I think it's fine
to remove.
More information about the webkit-reviews
mailing list