[webkit-reviews] review denied: [Bug 42405] ANGLE integration for shader validator and compiler : [Attachment 64381] Changes to WebCore for ANGLE
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 15 15:45:21 PDT 2010
Chris Marrin <cmarrin at apple.com> has denied Paul Sawaya <psawaya at apple.com>'s
request for review:
Bug 42405: ANGLE integration for shader validator and compiler
https://bugs.webkit.org/show_bug.cgi?id=42405
Attachment 64381: Changes to WebCore for ANGLE
https://bugs.webkit.org/attachment.cgi?id=64381&action=review
------- Additional Comments from Chris Marrin <cmarrin at apple.com>
Did you redo the xcodeproj file? It is still failing to patch on TOT.
Please fix the style issues pointed out by the style bot
WebCore/platform/graphics/GraphicsContext3D.h:29
+ #include "ANGLEWebkitBridge.h"
This include is causing the Qt build to fail. You can fix that by adding:
class ANGLEWebkitBridge;
You are already including the .h file in the Mac specific .mm file.
Also, the proper case is ANGLWebKitBridge. Please change to match.
More information about the webkit-reviews
mailing list