[webkit-reviews] review granted: [Bug 44027] Web Inspector: [REGRESSION] console's clear command does not work. : [Attachment 64444] [PATCH] Same with proper test title.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 15 13:11:22 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 44027: Web Inspector: [REGRESSION] console's clear command does not work.
https://bugs.webkit.org/show_bug.cgi?id=44027

Attachment 64444: [PATCH] Same with proper test title.
https://bugs.webkit.org/attachment.cgi?id=64444&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
(In reply to comment #5)
> This bug should have stated more clearly that it is about clear() command
> in the console not working.

My fault. Its entirely clear from the bug's title, I just overlooked it!


> We initiate clear from injected script (backend) in case of command line
> api use. So we need to send a direct message to the frontend. Easy to forget
> - same happened to Yury. So I added a test.

Haha, you're right its easy to forget =). Good fix and nice test.

r=me


More information about the webkit-reviews mailing list