[webkit-reviews] review requested: [Bug 43878] Linux build with FileSystem API enabled fails : [Attachment 64438] A patch copying seekFie from FileSystemPOSIX to FileSystemGtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 14 23:17:22 PDT 2010


red47514f7 at yandex.ru has asked	for review:
Bug 43878: Linux build with FileSystem API enabled fails
https://bugs.webkit.org/show_bug.cgi?id=43878

Attachment 64438: A patch copying seekFie from FileSystemPOSIX to FileSystemGtk
https://bugs.webkit.org/attachment.cgi?id=64438&action=review

------- Additional Comments from red47514f7 at yandex.ru
With this addition, WebKit builds (and its test programs link OK; html5test.com
show extra feature - FileReader) with --enable-file-writer on Linux.

As I understand comments in Glib, either it should work on Windows as is or it
requires including <io.h> somewhere; I do not know if WebKit-GTK is supposed to
work on Windows.

>From the license point of view, I copied a piece of code from BSD-licensed file
inside WebKit tree to LGPL-licensed file inside WebKit tree. The only copyright
holder in the original file is "Apple, Inc." - it is also copyright holder in
the target file. The code copied is a straightforward wrapper. Is there need to
change anything in copyright notices?


More information about the webkit-reviews mailing list