[webkit-reviews] review canceled: [Bug 43924] Web Inspector: -[WebInspector attach] and detach should work : [Attachment 64436] [PATCH] Allow attach and detach entirely in WebKit

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 43924: Web Inspector: -[WebInspector attach] and detach should work
https://bugs.webkit.org/show_bug.cgi?id=43924

Attachment 64436: [PATCH] Allow attach and detach entirely in WebKit
https://bugs.webkit.org/attachment.cgi?id=64436&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Thanks for doing this. Afaik Yury was going to fix it pretty much the same way.


Not sure whether you need this new public abstraction and the delegation. I'd
simply place a reference to WebInspectorFrontendClient into
WebInspectorPrivate.h. Rationale: WebInspector.h is the api to inspector and I
am not sure we should distinguish between backend and front-end on the WebKit
embedder level. Otherwise looks good! If you provide the rationale for the
interface, I am not against putting r+!