[webkit-reviews] review requested: [Bug 41364] [Qt] QWebPage::allowGeolocationRequest should be async API : [Attachment 64424] patch

[bugzilla-daemon at webkit.org]

Mahesh Kulkarni <mahesh.kulkarni at nokia.com> has asked  for review:
Bug 41364: [Qt] QWebPage::allowGeolocationRequest should be async API
https://bugs.webkit.org/show_bug.cgi?id=41364

Attachment 64424: patch
https://bugs.webkit.org/attachment.cgi?id=64424&action=review

------- Additional Comments from Mahesh Kulkarni <mahesh.kulkarni at nokia.com>
(In reply to comment #4)
>  - Provides a new async API for geolocation permission. 
>  - Using Notification API approach from qtwebkit.
GeolocationPermissionClientQt maintains list of pending requests from WebCore 
>  - Intimates WebCore pending geolocation notifiers when client either
allows/denies the request. 
>  - Implements ChromeClientQt::cancelGeolocationPermissionRequestForFrame
which removes 
>  - DumpRenderTree implements the async request from QtWebkit
>  - WebPage maintains list of geolocation permission request QtWebkit and
set's when LayoutTestController gets the access from test JS
> 
> 
> Please review.


Right now 4 layoutTest cases are blocked by this bug and these cases will be
available once patches for bug 42811 and bug 40002 gets in. 
I will attach one more patch followed by this one to enable all above 4 cases.