[webkit-reviews] review denied: [Bug 44001] fix test-webkitpy, add easy way to find a checkout root : [Attachment 64400] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied  review:
Bug 44001: fix test-webkitpy, add easy way to find a checkout root
https://bugs.webkit.org/show_bug.cgi?id=44001

Attachment 64400: Patch
https://bugs.webkit.org/attachment.cgi?id=64400&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think this is a great idea.  I'm glad you wrote this patch.  Thanks!

WebKitTools/Scripts/deduplicate-tests:66
 +	logutils.configure_logging()
Why move this to run instead of just at the top of the file?

WebKitTools/Scripts/webkitpy/common/checkout/scm.py:54
 +  def default_scm():
Seems we should just make this a static method on SCM.

WebKitTools/Scripts/webkitpy/common/checkout/scm.py:41
 +  def find_checkout_root():
Nice.  A bunch of scripts ported from chromium want this.

WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:2
42
 +	    self._scm = scm.default_scm_system()
This call doesn't exist.  Are we missing a unit test?

Looks good except for the typo.