[webkit-reviews] review denied: [Bug 43590] Implementing video frame sharing between WebKit and Chromium : [Attachment 63661] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Victoria
<vrk at google.com>'s request for review:
Bug 43590: Implementing video frame sharing between WebKit and Chromium
https://bugs.webkit.org/show_bug.cgi?id=43590

Attachment 63661: Patch
https://bugs.webkit.org/attachment.cgi?id=63661&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:435
 +	   
m_webMediaPlayer->putCurrentFrame(VideoFrameChromiumImpl::toWebVideoFrame(frame
));
probably need a 'delete frame' here.  should document the memory ownership
model.

i have further review comments about style, etc.  will get to those ASAP.

see also AssertMatchingEnums.cpp.  i think you'll want to extend that for your
new enums.

constants should not have a 'k' prefix.