[webkit-reviews] review granted: [Bug 43927] [Qt] ARMv5 Compiling error in FrameLoaderClientQt.cpp if QT_USE_FAST_OPERATOR_PLUS is defined globally : [Attachment 64245] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 13 15:26:15 PDT 2010


Laszlo Gombos <laszlo.1.gombos at nokia.com> has granted Hui Huang
<hui_huang at yahoo.com>'s request for review:
Bug 43927: [Qt] ARMv5 Compiling error in FrameLoaderClientQt.cpp if
QT_USE_FAST_OPERATOR_PLUS is defined globally
https://bugs.webkit.org/show_bug.cgi?id=43927

Attachment 64245: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=64245&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
The ChangeLog should have had the [Qt] prefix as well, and perhaps some of the
solution description should go to the ChnageLog and not to the bug, but
otherwise the patch looks good to me, r+.

I will land the patch manually.


More information about the webkit-reviews mailing list