[webkit-reviews] review canceled: [Bug 43658] Calling window.print() before the page is loaded results in a blank printed page : [Attachment 63966] Defer printing patch 3 - add a changelog entry and pass check-webkit-style.

[bugzilla-daemon at webkit.org]

Lei Zhang <thestig at chromium.org> has canceled Lei Zhang
<thestig at chromium.org>'s request for review:
Bug 43658: Calling window.print() before the page is loaded results in a blank
printed page
https://bugs.webkit.org/show_bug.cgi?id=43658

Attachment 63966: Defer printing patch 3 - add a changelog entry and pass
check-webkit-style.
https://bugs.webkit.org/attachment.cgi?id=63966&action=review

------- Additional Comments from Lei Zhang <thestig at chromium.org>
(In reply to comment #11)
> (From update of attachment 63966 [details])
> Oops. Sorry for the latency. I think the test method I've added cannot help
testing window.print(). I think we can add WebCore/manual-tests for this test.

Ok, I added a copy of 25027.htm to manual-tests. See try 4.

> This change looks good to me as the new behavior sounds more compatible to
other browsers. I hesitate to r+ this change now because this patch is related
to loader which I don't know well.
> 
> WebCore/loader/FrameLoader.cpp:2233
>  +	      window->print();
> A question: don't we need to reset m_printDeferred?

DOMWindow::print() resets m_printDeferred.