[webkit-reviews] review granted: [Bug 43922] Support for multiple speech enabled elements in same page. : [Attachment 64231] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 13 07:56:40 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Satish Sampath
<satish at chromium.org>'s request for review:
Bug 43922: Support for multiple speech enabled elements in same page.
https://bugs.webkit.org/show_bug.cgi?id=43922

Attachment 64231: Patch
https://bugs.webkit.org/attachment.cgi?id=64231&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
actually, leave it as ints

r=meWebCore/page/SpeechInput.cpp:57
 +	for (HashMap<int, SpeechInputListener*>::iterator it =
m_listeners.begin();
Maybe only do this in debug mode?  Or at least assert not reached that you hit
it?


More information about the webkit-reviews mailing list