[webkit-reviews] review requested: [Bug 43966] Web Inspector: rename InspectorValue::push and set to push{Value|Object|Array} and set{...}. : [Attachment 64331] [PATCH] Review comments addressed.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 13 06:15:03 PDT 2010
Ilya Tikhonovsky <loislo at chromium.org> has asked for review:
Bug 43966: Web Inspector: rename InspectorValue::push and set to
push{Value|Object|Array} and set{...}.
https://bugs.webkit.org/show_bug.cgi?id=43966
Attachment 64331: [PATCH] Review comments addressed.
https://bugs.webkit.org/attachment.cgi?id=64331&action=review
------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
WebCore/inspector/InspectorValues.cpp:513
+ bool InspectorValue::asObject(RefPtr<InspectorObject>* output)
will not compile on MAC
More information about the webkit-reviews
mailing list