[webkit-reviews] review granted: [Bug 43957] Need a LayoutTest to check that pages using Geolocation are not put in the page cache : [Attachment 64314] Patch

Fri Aug 13 02:25:52 PDT 2010

Alexey Proskuryakov <ap at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 43957: Need a LayoutTest to check that pages using Geolocation are not put
in the page cache
https://bugs.webkit.org/show_bug.cgi?id=43957

Attachment 64314: Patch
https://bugs.webkit.org/attachment.cgi?id=64314&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
As mentioned elsewhere, having a separate JS file is harmful in several ways.
This is not grounds for r-, since many existing tests do the same, but I think
that we should stop doing that, and maybe even convert existing tests.

+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

The HTML5 doctype is <!DOCTYPE html>, we should be using that for strict mode
(if needed).