[webkit-reviews] review granted: [Bug 43947] Add form submission listener to WebKit2 : [Attachment 64296] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 13 01:26:56 PDT 2010
Jon Honeycutt <jhoneycutt at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 43947: Add form submission listener to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43947
Attachment 64296: Patch
https://bugs.webkit.org/attachment.cgi?id=64296&action=review
------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
> Index: WebKit2/UIProcess/WebPageProxy.h
> ===================================================================
> --- WebKit2/UIProcess/WebPageProxy.h (revision 65292)
> +++ WebKit2/UIProcess/WebPageProxy.h (working copy)
> @@ -190,6 +192,8 @@ private:
> void decidePolicyForNewWindowAction(WebFrameProxy*,
WebCore::NavigationType navigationType, const WTF::String& url, uint64_t
listenerID);
> void decidePolicyForMIMEType(WebFrameProxy*, const WTF::String&
MIMEType, const WTF::String& url, uint64_t listenerID);
>
> + void willSubmitForm(WebFrameProxy*, WebFrameProxy*, uint64_t
listenerID);
Would be good to name the first two parameters.
r=me
More information about the webkit-reviews
mailing list