[webkit-reviews] review granted: [Bug 43899] Add test_expectations.txt syntax checker to check-webkit-style : [Attachment 64305] Proposed Patch V1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 12 23:46:01 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 43899: Add test_expectations.txt syntax checker to check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=43899

Attachment 64305: Proposed Patch V1
https://bugs.webkit.org/attachment.cgi?id=64305&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks great. A few nitpicks:

WebKitTools/Scripts/webkitpy/style/checkers/test_expectations.py:80
 +	    # Suppress error messages since they will be reported later.
Suppress error messages of test_expectations module since...

would be clearer

WebKitTools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:36
 +  try:
It would be better to add a comment why we want these lines


More information about the webkit-reviews mailing list