[webkit-reviews] review granted: [Bug 43891] location.href does not throw SECURITY_ERR when accessed across origins with JSC bindings : [Attachment 64286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 12 17:52:14 PDT 2010


Adam Barth <abarth at webkit.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 43891: location.href does not throw SECURITY_ERR when accessed across
origins with JSC bindings
https://bugs.webkit.org/show_bug.cgi?id=43891

Attachment 64286: Patch
https://bugs.webkit.org/attachment.cgi?id=64286&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
> Gecko and IE do throw the exception.

Can you add this information (and the spec reference) to the ChangeLog? 
Generally, it's helpful if the ChangeLog explains why we're making these
changes without having to hunt through the bug database.

Otherwise, looks good.	Thanks!


More information about the webkit-reviews mailing list