[webkit-reviews] review denied: [Bug 43924] Web Inspector: -[WebInspector attach] and detach should work : [Attachment 64257] [PATCH] Implement attach and detach

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 43924: Web Inspector: -[WebInspector attach] and detach should work
https://bugs.webkit.org/show_bug.cgi?id=43924

Attachment 64257: [PATCH] Implement attach and detach
https://bugs.webkit.org/attachment.cgi?id=64257&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
We've been ripping attach/detach logic from the InspectorController/Client
intentionally since it is a pure 'view' concept. Ideally, it should be
implemented entirely in the WebKit layer - no need to dive into WebCore. You
should look at what InspectorFrontendClient is calling in WebKit and wire
WebKit API to those WebKit methods directly.