[webkit-reviews] review requested: [Bug 43919] [GTK] Provide unit tests for AtkText's text selection functions : [Attachment 64236] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 43919: [GTK] Provide unit tests for AtkText's text selection functions
https://bugs.webkit.org/show_bug.cgi?id=43919

Attachment 64236: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=64236&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #0)
> This is a bug created just to provide in a common point unit tests
> to check how the following implementations of AtkText interface's
> functions work:
> 
>   1. atk_text_get_n_selections()
>   2. atk_text_get_selection()
>   3. atk_text_set_selection()
>   4. atk_text_remove_selection()
> 
> [...]
> Attaching the patch in some minutes then...

As promised, here is the patch to test all those 4 functions. Notice in the
patch that it was needed to add an extra check inside EditorClientGtk.cpp to
ensure that a GdkWindow is associated to the webview widget before trying to
actually mark the selection on that window (which won't be possible when
running the unittests as the webview won't have a GdkWindow, since it's not
inside any toplevel window).

Note that this bug was set as blocked by bug 26991 and bug 25673, since those
are were the actual implementations of those 4 methods are done.

Hence, now asking for review.