[webkit-reviews] review requested: [Bug 26991] [Gtk] get_n_selections and get_selection fail when selecting text across object boundaries : [Attachment 64234] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 26991: [Gtk] get_n_selections and get_selection fail when selecting text
across object boundaries
https://bugs.webkit.org/show_bug.cgi?id=26991

Attachment 64234: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=64234&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Now attaching a true patch and asking for review over it. The current new patch
contains basically the same thing than the previous one but slightly cleaned up
and got some fixes about some things that were not 100% correct in the previous
version.

(In reply to comment #3)
> [...]
> Hence, I guess now the next step here would be to write
> some unit tests (or even layout tests?) for this new code,
> so I'll focus on that.

At last, I did this but in a separate (new filed) bug (bug 43919), set as
dependent on bug 26991 and bug 25673, as I thought it was the best way
considering that both bugs needed to be fixed first before being able to
actually implement good unit tests in testatk.c for both of them (see more
reasons in https://bugs.webkit.org/show_bug.cgi?id=43919#c0)

> However, as I was chatting to Joanmarie on IRC, I couldn't
> find an obvious way to select and unselect text so I could
> write those unit tests, so perhaps it could be worth it to
> try to fix bug 25673 first and then write unit tests for
> both the setSelection and getSelection stuff.

Done that way, which is great since we get rid of two bugs for the prize of one

(See bug 25673 and 43919 for more details)