[webkit-reviews] review granted: [Bug 43276] Implements IDBKeyPath extractor. : [Attachment 64128] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted	review:
Bug 43276: Implements IDBKeyPath extractor.
https://bugs.webkit.org/show_bug.cgi?id=43276

Attachment 64128: Patch
https://bugs.webkit.org/attachment.cgi?id=64128&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
need change log

WebCore/bindings/v8/IDBBindingUtilities.cpp:65
 +	    switch (keyPath[i].type) {
Maybe this would be better if it were an if statement?

(Just kidding.	:-)

WebCore/bindings/v8/IDBBindingUtilities.h:33
 +  #include <wtf/Vector.h>
You don't need this.

WebKit/chromium/src/WebIDBKeyPath.cpp:49
 +	: m_private(new WTF::Vector<IDBKeyPathElement>(elements)),
comma on next line

WebKit/chromium/src/WebIDBKeyPath.cpp:41
 +  {
Initialize m_parseError?