[webkit-reviews] review requested: [Bug 43897] The JITStackFrame is wrong using Thumb-2 JIT with JSVALUE32_64 : [Attachment 64191] Fix the JITStackFrame in Thumb2 JIT with JSValue32_64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 12 01:10:45 PDT 2010


Gabor Loki <loki at webkit.org> has asked	for review:
Bug 43897: The JITStackFrame is wrong using Thumb-2 JIT with JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=43897

Attachment 64191: Fix the JITStackFrame in Thumb2 JIT with JSValue32_64
https://bugs.webkit.org/attachment.cgi?id=64191&action=review

------- Additional Comments from Gabor Loki <loki at webkit.org>
A 64 bits wide data is aligned to 8 bytes on ARM by default, but the ..._OFFSET
macros in JITStubs.cpp are calculated as the args member is started from the
fourth byte.
So, the macros are updated and the type of reserved member is replaced with
JITStubArg, in order not to make any mistake about the offsets.


More information about the webkit-reviews mailing list