[webkit-reviews] review denied: [Bug 43779] RenderImage::imageChanged invalidates wrong area : [Attachment 64163] Patch #2 (remove Remove RenderImage inheritance)

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 43779: RenderImage::imageChanged invalidates wrong area
https://bugs.webkit.org/show_bug.cgi?id=43779

Attachment 64163: Patch #2 (remove Remove RenderImage inheritance)
https://bugs.webkit.org/attachment.cgi?id=64163&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Also some comments:
WebCore/rendering/RenderSVGImage.cpp:51
 +	m_cachedImage = RenderImageResource::create(this);
Can be moved in the initialization list.

WebCore/rendering/RenderSVGImage.cpp:56
 +	m_cachedImage.clear();
Not needed IIRC.

WebCore/rendering/RenderSVGImage.cpp:104
 +		    if (svgStyle->shapeRendering() == SR_CRISPEDGES)
Is that necessary for images? I don't think so.

WebCore/rendering/RenderSVGImage.cpp:169
 +	// This empty image may be cached by SVG filter effects which must be
invalidated.
That change is not correct, you basically reverted to an older version of the
imageChanged version.
The SVGResourcesCache::... call is correct.

WebCore/svg/SVGImageElement.cpp:174
 +	if (RenderSVGImage* imageObj = toRenderSVGImage(renderer())) {
Change to early return.