[webkit-reviews] review denied: [Bug 43864] Canvas2D does not support images larger than system's GPU max texture size : [Attachment 64177] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Vincent Scheib
<scheib at chromium.org>'s request for review:
Bug 43864: Canvas2D does not support images larger than system's GPU max
texture size
https://bugs.webkit.org/show_bug.cgi?id=43864

Attachment 64177: Patch
https://bugs.webkit.org/attachment.cgi?id=64177&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- based on James' feedback alone.


nits:
Please make sure to add spaces around operators. For example,
"2*m_borderTexels" is done in a few places and there are many places where
there aren't spaces around +, -, *.

If the clause of an if (or else) statement spans more than one physical line it
needs braces around it. Here's one such example:
154	    if (swizzle)
 155		 uploadBuff = copySubRect<true>(
 156		 pixels32, tileBoundsWithBorder.x(), tileBoundsWithBorder.y(),
 157		 tempBuff, tileBoundsWithBorder.width(),
tileBoundsWithBorder.height(), m_tiles.totalSizeX());

There are others.