[webkit-reviews] review granted: [Bug 42976] Implement IDBKeyPath parser. : [Attachment 64124] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 22:39:50 PDT 2010


Adam Barth <abarth at webkit.org> has granted Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 42976: Implement IDBKeyPath parser.
https://bugs.webkit.org/show_bug.cgi?id=42976

Attachment 64124: Patch
https://bugs.webkit.org/attachment.cgi?id=64124&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/storage/IDBKeyPath.cpp:58
 +	  return m_currentTokenType;
Bad indent.  You can also put this all on one line.  Why does the name of the
access not match the name of the member variable?

WebCore/storage/IDBKeyPath.cpp:67
 +	const IDBKeyPathElement& currentElement()
Also can be on one line.


More information about the webkit-reviews mailing list