[webkit-reviews] review denied: [Bug 38561] new-run-webkit-tests should check each thread for exceptions instead of just the first one : [Attachment 63965] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 38561: new-run-webkit-tests should check each thread for exceptions instead
of just the first one
https://bugs.webkit.org/show_bug.cgi?id=38561

Attachment 63965: Patch
https://bugs.webkit.org/attachment.cgi?id=63965&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:229
 +	    else:
No need for else after return.

WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:1675
 +	found_stack = None
This local seems unneeded.

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_threa
d.py:278
 +	    return float(timeout) * 3 / 1000
Huh?

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_threa
d.py:272
 +	def timeout_padding(self, timeout):
Seems like a strange name for what this does.
it's giving you a hung_test_timeout or similar?  Why a function? isn't this
operating on a constant?

Why do we want .003 * timeout there?


I'm confused by the .003 timeout stuff.