[webkit-reviews] review granted: [Bug 39014] [chromium] Improve spacing support for complex text on Linux : [Attachment 64155] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 13:48:57 PDT 2010


Tony Chang <tony at chromium.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 39014: [chromium] Improve spacing support for complex text on Linux
https://bugs.webkit.org/show_bug.cgi?id=39014

Attachment 64155: Patch
https://bugs.webkit.org/attachment.cgi?id=64155&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
> diff --git a/WebCore/platform/graphics/chromium/FontLinux.cpp
b/WebCore/platform/graphics/chromium/FontLinux.cpp
>	   , m_run(getTextRun(run))
>	   , m_iterateBackwards(m_run.rtl())
> +	   , m_wordSpacingAdjustment(0)
> +	   , m_padding(0)
> +	   , m_padError(0)

Do you need to initialize m_padPerWordBreak and m_letterSpacing (well, I guess
this isn't used yet so it doesn't matter) here?


More information about the webkit-reviews mailing list