[webkit-reviews] review requested: [Bug 43359] [Qt] Fix warnings: unknown conversion type character 'l' in format : [Attachment 64132] proposed fix #2

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 43359: [Qt] Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359

Attachment 64132: proposed fix #2
https://bugs.webkit.org/attachment.cgi?id=64132&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
Fix this warning:
..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: unknown
conversion type character 'l' in format
..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: too many
arguments for format

I prefer PRI and SCN macros defined in inttypes.h, but 
I can't find any occurance of them in WebKit trunk.
Accordingly I propose a fix similar to String::number(...).

JavaScriptCore/wtf/text/WTFString.cpp:
...
String String::number(long long n)
{
#if OS(WINDOWS) && !PLATFORM(QT)
    return String::format("%I64i", n);
#else
    return String::format("%lli", n);
#endif
}
...