[webkit-reviews] review granted: [Bug 37630] delete redundant test outputs : [Attachment 64040] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Marcus Bulach <bulach at chromium.org>'s
request for review:
Bug 37630: delete redundant test outputs
https://bugs.webkit.org/show_bug.cgi?id=37630

Attachment 64040: Patch
https://bugs.webkit.org/attachment.cgi?id=64040&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKitTools/Scripts/webkitpy/layout_tests/deduplicate_tests.py:53
 +	    back on.  All platforms fall back on 'base'.
Seems part of this comment belongs next to _BASE_PLATFORM, but ok.

WebKitTools/Scripts/webkitpy/layout_tests/deduplicate_tests.py:68
 +  def parse_git_output(git_output, glob_pattern):
I would have named this parse_git_ls_tree_output

Looks great though.  Thanks for taking this on.

We probably should have done more of this as a class, rather than free
functions.  Eventually it will probably get moved deeper into webkitpy.  But I
think this is a good starting point.