[webkit-reviews] review requested: [Bug 43856] Perl warnings when running commit-log-editor : [Attachment 64123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 09:22:21 PDT 2010


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 43856: Perl warnings when running commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=43856

Attachment 64123: Patch
https://bugs.webkit.org/attachment.cgi?id=64123&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Perl doesn't have symbolic names for True/False. Instead, we should use boolean
values. Moreover, the variable installedEditorApplication is unused. It looks
like it should be renamed builtEditorApplication so that it uses the existing
machinery to set the editor.


More information about the webkit-reviews mailing list