[webkit-reviews] review denied: [Bug 42405] ANGLE integration for shader validator and compiler : [Attachment 64080] Stores data about shader (log, translated source, if valid) in HashMap instead of WebGLShader object

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 07:48:07 PDT 2010


Chris Marrin <cmarrin at apple.com> has denied  review:
Bug 42405: ANGLE integration for shader validator and compiler
https://bugs.webkit.org/show_bug.cgi?id=42405

Attachment 64080: Stores data about shader (log, translated source, if valid)
in HashMap instead of WebGLShader object
https://bugs.webkit.org/attachment.cgi?id=64080&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
I changed this to r-. After trying to apply the patch to my tree I noticed that
it fails to patch the project file, probably because it is out of date. It will
be easier for you to fix this on your machine. Just svn update, which will
probably result in a conflict on the project file. Fix that conflict, fix the
other issues I noted in my review and then submit a new patch. If it's clean,
we can have the commit-queue land it, which will be much easier.


More information about the webkit-reviews mailing list