[webkit-reviews] review requested: [Bug 43851] [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken : [Attachment 64111] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 07:23:15 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 43851: [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView
modes is broken
https://bugs.webkit.org/show_bug.cgi?id=43851

Attachment 64111: patch v1
https://bugs.webkit.org/attachment.cgi?id=64111&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
All window options data (including the bool holding if the view is either
QWebView or QGraphicsWebView based) is stored in m_windowOptions, a class
member of LauncherWindow. When toggle the view from QWebView to
QGraphicsWebView based (and vice-versa), we were
not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then
things were getting broken.

Patch addresses this issue.


More information about the webkit-reviews mailing list