[webkit-reviews] review requested: [Bug 43831] [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects : [Attachment 64103] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 06:18:02 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 43831: [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and
related objects
https://bugs.webkit.org/show_bug.cgi?id=43831

Attachment 64103: patch v2
https://bugs.webkit.org/attachment.cgi?id=64103&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Diff from v1:
1) Moved QStateMachine to a class member of WebView (named m_machine) instead
of being it a static variable in WebView::animatedYFlip slot.
2) Removed the yFlipRequest signal, now that it is unneeded.


More information about the webkit-reviews mailing list