[webkit-reviews] review denied: [Bug 40328] GtkLauncher fails to build: Undefined references to openFile, readFromFile, and seekFile : [Attachment 58536] Patch to add missing methods to FileSystemGtk.cpp

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Clemmitt Sigler
<cmsigler at gmail.com>'s request for review:
Bug 40328: GtkLauncher fails to build: Undefined references to openFile,
readFromFile, and seekFile
https://bugs.webkit.org/show_bug.cgi?id=40328

Attachment 58536: Patch to add missing methods to FileSystemGtk.cpp
https://bugs.webkit.org/attachment.cgi?id=58536&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 304 // Since above methods are implemented without GLib calls and variables,
 305 // just use code from WebCore/platform/posix/FileSystemPOSIX.cpp

Will these work on Windows? Why not use the glib tools that enable portability
here? Also, yes, I think you can just remove the test from the skipped list =)

I'll r- given krit's comments and my own.