[webkit-reviews] review granted: [Bug 42811] Geolocation preemptive permissions policy is buggy : [Attachment 64027] patch

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has granted Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 42811: Geolocation preemptive permissions policy is buggy
https://bugs.webkit.org/show_bug.cgi?id=42811

Attachment 64027: patch
https://bugs.webkit.org/attachment.cgi?id=64027&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
WebCore/page/Geolocation.cpp:661
 +  #endif
You could leave the TODO in place for the non-client-based impl if you like.

WebCore/page/Geolocation.cpp:651
 +	GeoNotifierSet::const_iterator end =
m_pendingForPermissionNotifiers.end();
It might be worth adding a comment that we don't need to protect against the
set being modified while we iterate through it because any reentrant calls from
JS callbacks to getCurrentPosition()/watchPosition() will see the permission as
having been set, so won't add notifiers to the pending set.